Add AlwaysRecordSampler #7877
Open
Add AlwaysRecordSampler #7877
+206
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7877 +/- ##
============================================
+ Coverage 90.06% 90.10% +0.04%
- Complexity 7320 7329 +9
============================================
Files 825 826 +1
Lines 22048 22062 +14
Branches 2179 2180 +1
============================================
+ Hits 19857 19879 +22
+ Misses 1511 1503 -8
Partials 680 680 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Spec change is still under review, so PR should not be merged
Background
Spec issue: open-telemetry/opentelemetry-specification#4698
Spec PR: open-telemetry/opentelemetry-specification#4699
Adding built in access to the RECORD_ONLY flag for sampling to allow for users to process spans without exporting them.
Changes
Testing
Added unit tests,
./gradlew spotlessApply && ./gradlew build && ./gradlew checkas per CONTRIBUTING.md guide